samouczek #441

nikitosych · 2026-01-31T23:54:22Z

aka "Wprowadzenie"

Informacje o PR

Niekompletna część systemu samouczka po stronie klienta. Infrastruktura po stronie klienta jest niby gotowa, sporo roboty jest z częścią serwerową.

Backend będzie opierał się na https://github.com/space-wizards/space-station-14/pull/41602 (project batfly)
oraz na https://hedgedoc.spacestation14.com/kTStQRSmTP-FlQIF0dN4aQ?view

Changelog
TODO

…dzania

This reverts commit 0df7915.

- Zaktualizowano interfejs użytkownika BanPanel, dodając funkcję wyboru rundy i resetowania. - Zmodyfikowano polecenia związane z banowaniem, aby akceptowały i obsługiwały informacje o rundach. - Ulepszono metody banowania, aby przechowywać dane dotyczące rund. - Zaktualizowano pliki lokalizacyjne dla komunikatów związanych z rundami.

…into intro

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…into intro

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 30 out of 36 changed files in this pull request and generated 21 comments.

Copilot · 2026-02-08T17:01:24Z

Content.Client/_Polonium/Introduction/IntroductionUIController.cs

+        else if (ActiveOverlay is not null)
+        {
+            // Zamiast natychmiast usuwać overlay, wznosi się zdarzenie zamknięcia, aby zadziałały subskrybcje w poszczegolnych krokach.
+            ActiveOverlay.DestroyOverlay();


OverlayCloseRequestEvent is declared and IntroductionManager subscribes to it, but the event is never invoked. As a result, OnOverlayCloseRequested is dead code and close behavior is driven directly by RequestClose()/DestroyOverlay(). Either invoke OverlayCloseRequestEvent from RequestClose() (and let the manager decide navigation) or remove the unused event/subscription to avoid confusion.

Suggested change

ActiveOverlay.DestroyOverlay();

ActiveOverlay.OverlayCloseRequestEvent?.Invoke();

Copilot · 2026-02-08T17:01:24Z

Content.Client/_Polonium/Introduction/UI/HighlightOverlay.cs

+        _content.AddChild(overlayControl);
+
+        var tracked = new TrackedControl(overlayControl, null, relativePosition, spacing, UseOverlayBounds: true);
+        _trackedControls.Add(tracked);
+
+        if (!deferred && IsArrangeValid && PixelSize is { X: > 0, Y: > 0 })
+        {
+            if (!overlayControl.IsMeasureValid)
+                overlayControl.Measure(Size);
+
+            var controlSize = overlayControl.DesiredPixelSize;
+            var position = CalculatePositionInContainer(relativePosition, controlSize, PixelSize, spacing);
+
+            AddOverlayControl(overlayControl, position);
+            return;


AddControlRelative(..., deferred: false) will attempt to add overlayControl to _content twice: once via _content.AddChild(overlayControl) and again via AddOverlayControl(overlayControl, position) (which also does _content.AddChild). This will throw at runtime if the non-deferred path is ever used. In the non-deferred branch, only set position/size (or change AddOverlayControl to not re-add when already parented).

Copilot · 2026-02-08T17:01:24Z

Content.Client/_Polonium/Introduction/Steps/ProceedPromptStep.cs

+    private void PromptOverlay()
+    {
+        var proceedBubble = new IntroBubble(
+            Loc.GetString("intro-proceed-prompt-message"))
+        {
+            ClickAction = IntroBubble.ClickBehaviour.Ignore,
+            TippyVariant = IntroBubble.Tippy.None,
+        };
+        IntroUi.PlanBubble(proceedBubble, HighlightOverlay.OverlayControlPosition.Center);
+


ProceedPromptStep only calls IntroUi.PlanBubble(...) but never plans an overlay. Since IntroductionUIController.PlanBubble queues bubbles when there is no active overlay, this step will show no UI and appear to do nothing. Add an overlay via IntroUi.PlanOverlay(...) before planning the bubble (and consider using an overlayId to ensure the bubble is attached to the intended overlay).

Copilot · 2026-02-08T17:01:25Z

Content.Client/_Polonium/Introduction/Commands/StartIntroCommand.cs

+            shell.WriteLine(Help);
+            return;
+        }
+        var introUI = IoCManager.Resolve<IUserInterfaceManager>().GetUIController<IntroductionUIController>();


introUI is resolved but never used. This is dead code and may generate warnings; remove it unless you intended to use it (e.g., to ensure controller initialization).

Suggested change

var introUI = IoCManager.Resolve<IUserInterfaceManager>().GetUIController<IntroductionUIController>();

Copilot · 2026-02-08T17:01:25Z

Content.Client/Lobby/UI/CharacterSetupGui.xaml


-SPDX-License-Identifier: MIT
-->
+SPDX-License-Identifier: MIT-->


The SPDX header comment is malformed: SPDX-License-Identifier: MIT--> includes the comment terminator on the same line as the identifier. This can break license scanning/REUSE tooling. Put SPDX-License-Identifier: MIT on its own line and close the XML comment (-->) on a separate line.

Suggested change

SPDX-License-Identifier: MIT-->

SPDX-License-Identifier: MIT

-->

Copilot · 2026-02-08T17:01:28Z

Content.Client/_Polonium/Introduction/Steps/CharacterCreationStep.cs

+
+        var chars = setup.FindControl<BoxContainer>("ListedCharactersContainer");
+        var name = $"{StepId}-4";
+        var overlay = IntroUi.PlanOverlay(name, setup.JobPrioritiesBtn, Color.Green);


This assignment to overlay is useless, since its value is never read.

Suggested change

var overlay = IntroUi.PlanOverlay(name, setup.JobPrioritiesBtn, Color.Green);

IntroUi.PlanOverlay(name, setup.JobPrioritiesBtn, Color.Green);

Copilot · 2026-02-08T17:01:28Z

Content.Client/_Polonium/Introduction/Steps/CharacterCreationStep.cs

+
+        var chars = setup.FindControl<BoxContainer>("ListedCharactersContainer");
+        var name = $"{StepId}-5";
+        var overlay = IntroUi.PlanOverlay(name, default, Color.Transparent, false, false);


This assignment to overlay is useless, since its value is never read.

Suggested change

var overlay = IntroUi.PlanOverlay(name, default, Color.Transparent, false, false);

IntroUi.PlanOverlay(name, default, Color.Transparent, false, false);

Content.Client/_Polonium/Introduction/UI/HighlightOverlay.cs

Content.Client/_Polonium/Introduction/UI/IntroBubble.xaml.cs

…ht oraz solitary server hop

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

nikitosych and others added 30 commits November 15, 2025 03:41

Skrypt publikacji jest teraz powiązany z CDN Polonium

52491a0

Utworzono workflow do publikowania serwera

8980909

Naprawiono odniesienie do repozytorium w gałęzi głównej podczas spraw…

44c1992

…dzania

Dodano rejestrowanie wersji silnika w funkcji get_engine_version

c9807b2

Dodano rejestrowanie długości tokenu

bfec232

Dodano automatyczną synchronizację z głównym repozytorium

df33633

Dodano kroki do ustawienia tożsamości git oraz uprawnienia dla action

ae8f4a6

Poprawiono obsługę błędów

209409f

Zmiana kolejności kroków

4e6523b

Zmieniono gałąź na master w kroku Push changes (o boże...)

e120e19

Tryby

dd70aab

mapy

7854725

usunięto dm z puli

0df7915

Revert "usunięto dm z puli"

30f54e5

This reverts commit 0df7915.

Proba usunięcia wymagań do zawodów. Czy zadziała?

d99e4b2

Wyzerowano wszystkie wymagania do ról

f5dd306

Usunięto duplikat

2f287b8

Dodano folder z workflows do gitignore

dff906f

Przywracanie workflows

609a55b

Zaktualizowano workflow

76e5a01

Zaktualizowano workflow

8eca995

Dodano integrację webhooków Discord dla powiadomień o banach

0eaba7d

poprawiono obsługę webhooków Discord

1f210ca

Błądzik poprawiony

038e270

Błądzik poprawiony

829b3b5

changelog

c8e777f

worflow for cl only

c4f9e14

workflow update

c53db89

nikitosych and others added 6 commits February 7, 2026 18:25

poprawka StepId w CharacterCreationStep

15258ec

commebts

5b4c95a

CurrentIntroStepCommand (dla debugowania)

880b60f

todo fixes

4135ee9

Merge branch 'intro' of https://github.com/nikitosych/learn-station-14 …

5246a1c

…into intro

chore: Automatically update REUSE headers

8c4f71b

Copilot AI review requested due to automatic review settings February 7, 2026 17:34

Copilot AI reviewed Feb 7, 2026

View reviewed changes

nikitosych and others added 3 commits February 7, 2026 18:40

mega update

85a5a22

Merge branch 'intro' of https://github.com/nikitosych/learn-station-14 …

147a694

…into intro

chore: Automatically update REUSE headers

26e81f5

Copilot AI review requested due to automatic review settings February 7, 2026 17:41

Copilot AI reviewed Feb 7, 2026

View reviewed changes

nikitosych added 2 commits February 8, 2026 15:25

ref+dbg stuff

f320f68

ref ftl

907c5bd

Copilot AI review requested due to automatic review settings February 8, 2026 16:42

ProceedPromptStep

593e323

Copilot started reviewing on behalf of nikitosych February 8, 2026 16:43 View session

graceful complete?

5fc299e

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 9, 2026 15:42

lepsza logika ostatniego ovl w lobby, ignorowanie kliknięć na highlig…

15617e6

…ht oraz solitary server hop

Copilot started reviewing on behalf of nikitosych February 9, 2026 15:43 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Update Content.Client/_Polonium/Introduction/UI/IntroBubble.xaml.cs

46fb11c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 9, 2026 18:22

Update Content.Client/_Polonium/Introduction/UI/HighlightOverlay.cs

ddc3a5e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of nikitosych February 9, 2026 18:23 View session

Update Content.Client/_Polonium/Introduction/UI/HighlightOverlay.cs

7738774

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Feb 9, 2026

View reviewed changes

	ActiveOverlay.DestroyOverlay();
	ActiveOverlay.OverlayCloseRequestEvent?.Invoke();

	SPDX-License-Identifier: MIT-->
	SPDX-License-Identifier: MIT
	-->

	var overlay = IntroUi.PlanOverlay(name, setup.JobPrioritiesBtn, Color.Green);
	IntroUi.PlanOverlay(name, setup.JobPrioritiesBtn, Color.Green);

	var overlay = IntroUi.PlanOverlay(name, default, Color.Transparent, false, false);
	IntroUi.PlanOverlay(name, default, Color.Transparent, false, false);

samouczek #441

Are you sure you want to change the base?

samouczek #441

Uh oh!

Conversation

nikitosych commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Informacje o PR

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nikitosych commented Jan 31, 2026 •

edited

Loading