Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for retrieving block by hash #110

Closed
wants to merge 1 commit into from
Closed

Add test for retrieving block by hash #110

wants to merge 1 commit into from

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Sep 1, 2020 •
edited
Loading

With recent changes calling eth_getBlockByHash or using web3.eth.getBlock (using a hash) is returning null instead of the block's body.

This PR adds the assertion to the typescript tests.

P.S. the PR fails obviously on functional tests -> AssertionError: Target cannot be null or undefined.

@tgmichel
Copy link
Contributor Author

tgmichel commented Sep 2, 2020 •
edited
Loading

@sorpaas @crystalin

Once #113 goes through, the test should work.

@sorpaas
Copy link
Member

sorpaas commented Sep 11, 2020

Please pull master.

@ermalkaleci
Copy link
Contributor

#134 fixes this

@tgmichel tgmichel closed this Oct 7, 2020
@tgmichel tgmichel deleted the tgmichel-blockhash-test branch October 7, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgmichel @sorpaas @ermalkaleci