feat(sdk-accounts): add identity sdk #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepot
approved these changes
May 2, 2025
Comment on lines
7
to
13
| export type IdentityInfo = { | ||
| [K in keyof DescriptorsIdentityInfo]?: DescriptorsIdentityInfo[K] extends | ||
| | Binary | ||
| | undefined | ||
| ? DescriptorsIdentityInfo[K] | ||
| : string | ||
| } |
There was a problem hiding this comment.
Suggested change
| export type IdentityInfo = { | |
| [K in keyof DescriptorsIdentityInfo]?: DescriptorsIdentityInfo[K] extends | |
| | Binary | |
| | undefined | |
| ? DescriptorsIdentityInfo[K] | |
| : string | |
| } | |
| export type IdentityInfo = { | |
| [K in keyof DescriptorsIdentityInfo]?: K extends "pgp_fingerprint" | |
| ? DescriptorsIdentityInfo[K] // or FixedSizeBinary<20> | undefined | |
| : string | |
| } |
I wouldn't make it super-generic, b/c it's very coupled that that specific field... What I mean is that since we are in control of the DescriptorsIdentityInfo type, we may as-well do it like this, no?
| const displayName: Identity["displayName"] = info.display | ||
| ? { | ||
| value: info.display, | ||
| verified: judgements.some((v) => v.judgement === "Reasonable"), |
There was a problem hiding this comment.
Shouldn't KnownGood also be verified? 🤔 (I really don't know, I'm just guessing...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something we've been using in many mini-dApps, I think it could be useful to have it as an SDK.