feat: add multisig sdk #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking I did a mistake adding the meta-signers to the top-level package. Back then it made sense since it was a new category of "meta-signers", so maybe having them next to the other signers would be nice.
But they work on a higher level, and the logic they do could be beneficial for things that are not signers.
The new idea in this PR is to have it as a standalone papi-sdk: it requires a typedApi with multisig stuff, and then exports two functions:
They both need the multisig account info (signatories + threshold). Then for the multisigTx I need a signatory (since the call data changes based on who will sign it) and any Transaction (could do with call data only... but this way I can
.getPaymentInfo()
to get the weight... and you can always create one withtypedApi.txFromCallData
)And
getMulsitigSigner
replaces the top-level one. Maybe we should deprecate that one and ask people to use this one instead?