Skip to content

Handle cases where messages contain newlines, doublequotes, etc #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
developingAlex wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle cases where messages contain newlines, doublequotes, etc #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions app/src/main/java/sms_backup/poliveira/org/smsbackup/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ private void getInbox() throws Exception {
if (!headers.contains(cursor.getColumnName(index))) {
headers.add(cursor.getColumnName(index));
}
row += cursor.getString(index) + ";";
row += getCsvSuitableFormat(cursor.getString(index)) + ";";
}
row += "\n";
dataset.append(row);
Expand All @@ -101,7 +101,7 @@ private void getSent() throws Exception {
do {
String row = "";
for (int index = 0; index < cursor.getColumnCount(); index++) {
row += cursor.getString(index) + ";";
row += getCsvSuitableFormat(cursor.getString(index)) + ";";
}
row += "\n";
dataset.append(row);
Expand All @@ -110,4 +110,39 @@ private void getSent() throws Exception {
throw new Exception("Fails to retrieve SMS sent messages.");
}
}

private String getCsvSuitableFormat(String input) {
/*
* Per RFC 4180
* [definition of the CSV format](https://tools.ietf.org/html/rfc4180#page-2)
*
* "Fields containing line breaks (CRLF), double quotes, and commas
* should be enclosed in double-quotes."
*
* "If double-quotes are used to enclose fields, then a double-quote
* appearing inside a field must be escaped by preceding it with
* another double quote."
**/

// do nothing if null object reference is passed in
if (input == null){
return input;
}

// wrap with double quotes if the string contains newlines, commas, double-
// quotes, or semicolons (because we delimit with semicolon).
// And ensure double-quotes inside the field get
// preceded by an additional double quote.
if (
input.contains("\n") ||
input.contains(";") ||
input.contains(",") ||
input.contains("\"")
){
return "\"" + input.replace("\"", "\"\"") + "\"";
}

return input;
}
}