Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ban nacos registry and config #200

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Conversation

fredrikliu
Copy link
Contributor

@fredrikliu fredrikliu commented Jun 24, 2024

Please provide issue(s) of this PR:
Fixes #194

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Docs
  • Discovery
  • Route
  • RateLimit
  • CircuitBreaker
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@@ -40,6 +40,9 @@ public static void premain(String agentArgs, Instrumentation instrumentation, St
return;
}

System.setProperty("spring.cloud.nacos.config.enabled", "false");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单独提取一个class来保存配置的初始化,便于管理bootstrap的配置初始化

@@ -0,0 +1,11 @@
package cn.polarismesh.agent.core.bootstrap;

public class SetProperties {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改名为PolarisInitProperties

@SkyeBeFreeman SkyeBeFreeman merged commit 31013a7 into polarismesh:main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants