Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix javaagent2023 could not start by bootstrap.yml #189

Merged
merged 5 commits into from
May 30, 2024

Conversation

fredrikliu
Copy link
Contributor

@fredrikliu fredrikliu commented May 30, 2024

Please provide issue(s) of this PR:
fix javaagent2023 could not start by bootstrap.yml
Fixes #155
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Docs
  • Discovery
  • Route
  • RateLimit
  • CircuitBreaker
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@@ -1,5 +1,5 @@
# the application name for spring cloud, register as the service name in registry center
spring.application.name=application-name
spring.application.name=service-provider-2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个可以不要了吧

ReflectionUtils.invokeMethod(processConfigurationClass, configurationParser, polarisLoadBalancerAutoConfiguration, Constant.DEFAULT_EXCLUSION_FILTER);
registry.registerBeanDefinition("polarisLoadBalancerAutoConfiguration", BeanDefinitionBuilder.genericBeanDefinition(
PolarisLoadBalancerAutoConfiguration.class).getBeanDefinition());
// // make LoadBalancerAutoConfiguration later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释代码删掉

Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit ed7f752 into polarismesh:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants