Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all instances of fisherman to watcher #46

Closed
wants to merge 1 commit into from

Conversation

0xRampey
Copy link

@0xRampey 0xRampey commented Aug 7, 2023

Objective

Rename all instances of fisherman to watcher

Origin Document

pokt-network/pocket#956

Goals

  • Make sure that Pocket networks specs are up to date with the new terminology of 'Watcher'

Deliverable

  • Rename all instances of fisherman

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Creator: @0xRampey
Co-Owners:

Also probably cue to merge in ADR #38 @dylanlott

@0xRampey 0xRampey requested review from dylanlott and Olshansk August 7, 2023 16:30
@0xRampey 0xRampey self-assigned this Aug 7, 2023
@0xRampey 0xRampey added the documentation Improvements or additions to documentation label Aug 7, 2023
@Olshansk
Copy link
Member

Olshansk commented Aug 7, 2023

@0xRampey Makes sure to update the metadata of PRs as well as issues. Going to update this one so PTAL.

Also, please try to stick to the PR & Issue templates unless it is something XS where the overhead isn't worth it.

Screenshot 2023-08-07 at 2 10 25 PM

@Olshansk Olshansk added this to the M3: RoS (Relay or Slash) milestone Aug 7, 2023
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file LGTM but I want to understand the next steps w.r.t renaming it in the rest of the codebase.

Is there going to be a group of PRs changing the specs, the code, etc? Will it be one big PR or on a per module basis?

Please update the github description appropriately to answer the context above.

@0xRampey
Copy link
Author

0xRampey commented Aug 8, 2023

@Olshansk I've updated the gameplan in the origin document and linked to it here. Lmk if that clears it up.

@RossiNYC
Copy link

RossiNYC commented Oct 9, 2023

@Olshansk we still need this ticket I think, right?

@Olshansk
Copy link
Member

Olshansk commented Oct 9, 2023

@Olshansk we still need this ticket I think, right?

Yea, that's correct. And one for renaming Servicer to Supplier as well.

EDIT: Captured work item here: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants