Use StructuredQueriesCore module name in macro expansions. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
May 15, 2025
mbrandonw
added a commit
that referenced
this pull request
May 16, 2025
stephencelis
added a commit
that referenced
this pull request
May 26, 2025
* Add default query representations for dates and UUIDs SQLite does not have date or UUID types, and instead can represent dates and UUIDs in several different ways. While this works for SQLite, other database systems _do_ have dedicated date and UUID types, and so we should probably encode these types in StructuredQueries' decoding and binding layers, and then SQLite drivers (like SharingGRDB) will pick a sensible default, like ISO8601 strings for dates, and lowercased strings for UUIDs. Draft PR for now as we figure out if this is the right direction, and there is plenty to do before merging (documentation, etc.). * wip * wip * Use StructuredQueriesCore module name in macro expansions. (#42) * wip * wip; * Update docs * wip * wip --------- Co-authored-by: Brandon Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the more correct thing to do, and has the added benefit of being able to inline the macro for copy-paste for targets that do not want to use the macro.