Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't invoke XCTContext when running in the Testing framework. #884

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mbrandonw
Copy link
Member

Fixes #883

@mbrandonw mbrandonw requested a review from stephencelis August 1, 2024 21:21
@stephencelis stephencelis merged commit 8105068 into main Aug 1, 2024
3 checks passed
@stephencelis stephencelis deleted the swift-testing-fix branch August 1, 2024 22:14
@doozMen
Copy link
Contributor

doozMen commented Aug 7, 2024

It does fix the issue! Thanks for the quick fix!

JustasL added a commit to vinted/swift-snapshot-testing that referenced this pull request Dec 11, 2024
* main: (27 commits)
  Run swift-format
  Fix assertSnapshot for Swift Testing tests. (pointfreeco#916)
  Add an NB to @_implementationOnly import.
  Run swift-format
  Import only the implementation of Testing. (pointfreeco#903)
  fix missing inline snapshot testing (pointfreeco#887)
  Feature/fixed decimal separator (pointfreeco#889)
  Run swift-format
  Xcode 16 beta 5: Fix snapshots test trait (pointfreeco#885)
  Run swift-format
  Don't invoke XCTContext when running in the Testing framework. (pointfreeco#884)
  Run swift-format
  Fixed .failed record mode in inline snapshots. (pointfreeco#874)
  Point updated packages to swiftlang organization (pointfreeco#873)
  Fix recordIssue for Xcode beta 3. (pointfreeco#869)
  Run swift-format
  Beta support for Swift Testing, and other improvements. (pointfreeco#867)
  Run swift-format
  New `canGenerateNewSnapshots` to avoid automatically creating missing ones in CI (pointfreeco#768)
  Run swift-format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when trying to use inline snapshots with swift testing with project that reproduces issue
3 participants