-
Notifications
You must be signed in to change notification settings - Fork 160
Fix for crash when dismissing UIViewControllers when building with Xcode 26 #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix for crash when dismissing UIViewControllers when building with Xcode 26 #314
Conversation
…-UIAlertController cases that was present in 2.5.0, fixes crash when building with XCode 26
@acosmicflamingo - keen for your opinion on this |
Tested on:
|
Interesting...I wonder if this has an impact on TCA apps that display alerts via state navigation. I'm not by my keyboard so I can't verify. What a find! |
Have tried in my own TCA app, and the alerts and confirmation dialogs still seem to work as expected. The codepath for this shouldn't affect the 2.5.1 behavior. Would be great verify on another TCA code base though. |
Hmm, it's a bit hard to fully validate in TCA without this PR included as things keep getting dismissed: #310 @acosmicflamingo Maybe we should wait until your other PR is merged in. |
Oops didn't mean to close! @StuSharpe now that #310 is merged and you verify everything on your end? |
Thanks @stephencelis. Yes, I can confirm that all looks good now. Happy for this to be merged. Tested:
|
Addresses #313
This change re-instates the original thread-hop before nilling out dismiss closure that was present in 2.5.0, for the non-UIAlertController case.
See 2.5.0...2.5.1
This fixes the issue, but I don't really have any clarity on why. Some quirk with the Xcode 26 toolset.