Swift Testing support #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Jul 10, 2024
| let cancellable = self.schedule( | ||
| after: self.now.advanced(by: interval), | ||
| interval: interval, | ||
| tolerance: tolerance, | ||
| options: options | ||
| ) { | ||
| continuation.yield(self.now) | ||
| continuation.yield($scheduler.wrappedValue.now) |
There was a problem hiding this comment.
This "fixes" an unrelated issue that cropped up in beta 3. Seems that self.now is a detected data race. We could consider a better fix, but this is at least functionally the same as on main.
mbrandonw
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Swift Testing support for the
UnimplementedSchedulerso that failures emit during@Testruns.