RequestId Middleware #806
Merged
RequestId Middleware #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a feature-gated
RequestIdmiddleware that associates an unique ID with each incoming request.ReqIdcan be extracted in request handlers and returned as a response (e.g. for error pages). Each response contains a header with the ID (default name:x-request-idbut the header name is configurable).The
Tracingmiddleware was made aware of the request ID and adds it to the request span (for this to work, the order of the middlewares is important.Tracingmust be applied beforeRequestId.If
ReuseId::Useis set, the middleware will propagate the request ID from an incoming request. If the request contained anx-request-idheader (or whatever header name is configured), this value will be used.