fix: possible race condition during graceful shutdown #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR just makes the behavior more reliable, also should address poem-web#661 The possible race condition: - `notify_waiters()` will notify only already registered waiters Thus, if it's called after ```rust drop(acceptor); if alive_connections.load(Ordering::Acquire) > 0 { ``` But before `notify.notified()` - it might be never notified.
|
I'd love to merge this. What's your opinion? @sunli829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just makes the behavior more reliable and kinda simplified, also addresses #661 (was able to repro manually and couldn't after the fix)
The possible race condition:
notify_waiters()will notify only already registered waitersThus, if it's called after
But before
notify.notified()- it might be never notified.