Skip to content

[release-1.16] Bump Go Jose to 3.0.5 and 4.1.4, CVE-2026-34986#2864

Open
TomSweeneyRedHat wants to merge 5 commits into
podman-container-tools:release-1.16from
TomSweeneyRedHat:dev/tsweeney/release-1.16-cve-2026-34986
Open

[release-1.16] Bump Go Jose to 3.0.5 and 4.1.4, CVE-2026-34986#2864
TomSweeneyRedHat wants to merge 5 commits into
podman-container-tools:release-1.16from
TomSweeneyRedHat:dev/tsweeney/release-1.16-cve-2026-34986

Conversation

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor

Bump Go Jose to v3.0.5 and v4.1.4 to address CVE-2026-34986 Also Bump Skopeo to v1.16.2

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-81798, https://redhat.atlassian.net/browse/OCPBUGS-81806

@packit-as-a-service
Copy link
Copy Markdown

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but this needs an updated Go in CI images. What to do? Compare #2863 .

@lsm5
Copy link
Copy Markdown
Contributor

lsm5 commented May 1, 2026

@TomSweeneyRedHat what RHEL releases are these OCP based on? I'll run tests manually on testing-farm.

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

TomSweeneyRedHat commented May 1, 2026

@lsm5 they are based on Podman 5.2 on RHEL 9.5, headed towards OCP 4.18 and 4.17

@lsm5
Copy link
Copy Markdown
Contributor

lsm5 commented May 4, 2026

So, I dunno if we wanna just merge this and hope for the best. I haven't yet received answers on if golang will be updated and what's the right golang build to fetch for running testing-farm tests.

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

@lsm5 leave this one for now until I get some time to dig further. I'll ping you when it's ready for the merge button.

Based on
podman-container-tools@5973d14,
bump the version of Fedora that cirrus ci will use.

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/release-1.16-cve-2026-34986 branch from 08e7b70 to 9998de5 Compare May 11, 2026 19:48
@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

@lsm5 I'm going around in loops trying to get the validate test to work here. It seems to be saying the version of Go needs to be higher, but with my fedora bump to v42, that should be at Go 1.24, which should be fine. Do you have any other thoughts? Do we just wait until you can convert to Packit here too?

@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented May 12, 2026

@TomSweeneyRedHat this is golangci-lint failing. I’d try updating it — the change log of v1.64.2 includes “go1.24 support”.

@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented May 12, 2026

… alternatively, disabling a linter would not be too bad…

Bump golangci-lint to 1.64.2, which was the version that first came out
with Go 1.24.  If that doesn't address the issues we are seeing in the
CI, we'll bump it up a bit more.

I worry about going too high, as I saw some compatability issues noted
in some discussions online.

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/release-1.16-cve-2026-34986 branch from 9998de5 to 0dc7fe5 Compare May 14, 2026 21:49
@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

@mtrmac I added a commit to tweak the Makefile for golanglint-ci. Tests aren't happy, the first one looked to be a network hiccup. I'll restart in the morning.

@mtrmac
Copy link
Copy Markdown
Contributor

mtrmac commented May 14, 2026

I guess backporting some of the commits found by git log -p -G 'dnf.*erase' (and perhaps related commits from the original PRs?) might be necessary.

Luap99 and others added 2 commits May 29, 2026 16:46
dnf erase was removed from dnf5 in f41, AFAIK remove does the same thing
and erase was just a removed alias.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
(cherry picked from commit 8d3fb4b)
Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
Bump to Skopeo v1.16.2

Signed-off-by: Tom Sweeney <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/release-1.16-cve-2026-34986 branch from 0dc7fe5 to 908552c Compare May 29, 2026 20:48
@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

Backported the dnf fix, @Luap99 had done one upstream to change erase to remove. That looks to have fixed that. Now this is down to packit issues.

@TomSweeneyRedHat
Copy link
Copy Markdown
Contributor Author

And Happy Green Test Buttons!

Copy link
Copy Markdown
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat the CI results that are now visible are only RPM build tests; I can’t tell whether “proper” CI passed and we lost the data, or whether it was never run.

Either way, leaving it to you whether you want to merge+release as is, or to wait for CI to be migrated (and to backport that to this branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants