new ci for skopeo #9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| self-hosted-runner: | ||
| labels: | ||
| - oracle-vm-2cpu-8gb-x86-64 | ||
| - oracle-vm-4cpu-16gb-x86-64 | ||
| - oracle-vm-8cpu-32gb-x86-64 | ||
| - oracle-vm-16cpu-64gb-x86-64 | ||
| - oracle-vm-24cpu-96gb-x86-64 | ||
| - oracle-vm-32cpu-128gb-x86-64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Path filters for .github/workflows/ci.yml, consumed by dorny/paths-filter. | ||
| # When a PR touches none of `all` or `code`, the heavier optional jobs | ||
| # (cross/osx/ostree_rs_ext) are skipped. validate/doccheck/test_skopeo always | ||
| # run regardless. | ||
|
|
||
| # Anything that should invalidate every skip decision. | ||
| all: | ||
| - '.github/workflows/ci.yml' | ||
| - '.github/filters.yaml' | ||
| - 'Makefile' | ||
| - 'hack/**' | ||
| - 'vendor/**' | ||
| - 'go.mod' | ||
| - 'go.sum' | ||
|
|
||
| # Production Go source. Tests and bats are excluded so a test-only diff | ||
| # does not force every "code" gated job to run. | ||
| code: | ||
| - '**/*.go' | ||
| - '!**/*_test.go' | ||
| - '!systemtest/**' | ||
| - '!integration/**' | ||
|
Member
There was a problem hiding this comment. Note I switched this in my podman work, in short this does not really work because any match == true so any go file changes triggers all and you do not exclude tests like that. Also it cannot work without specific test matchers, i.e. in podman it was setup to only run sys tests when only a sys test file was changed. |
||
|
|
||
| # Docs-only signal kept for symmetry. Not directly gated on; the run rule is | ||
| # "all OR code matched", so a pure-docs change naturally skips heavy jobs. | ||
| docs: | ||
| - 'docs/**' | ||
| - 'docs-experimental/**' | ||
| - '**/*.md' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| path-filter: | ||
|
Contributor
There was a problem hiding this comment. (I didn’t review this mechanism in detail.) |
||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| outputs: | ||
| all: ${{ steps.filter.outputs.all }} | ||
| code: ${{ steps.filter.outputs.code }} | ||
| docs: ${{ steps.filter.outputs.docs }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1 | ||
| id: filter | ||
| with: | ||
| filters: .github/filters.yaml | ||
|
|
||
| validate: | ||
| runs-on: oracle-vm-4cpu-16gb-x86-64 | ||
| timeout-minutes: 45 | ||
| container: | ||
| image: quay.io/libpod/skopeo_cidev:${{ vars.IMAGE_TAG }} | ||
|
Contributor
There was a problem hiding this comment. (Where does
Member
There was a problem hiding this comment. there is currently no automation for building containers images, that needs to be re-added into https://github.com/podman-container-tools/automation/ For now hard code to the last known tag |
||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - name: fix git safe.directory | ||
| run: git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
| - run: make tools | ||
| - run: make validate-local | ||
| - name: vendor + tree status | ||
| run: | | ||
| make vendor | ||
| hack/tree_status.sh | ||
|
|
||
| doccheck: | ||
| needs: validate | ||
| runs-on: oracle-vm-4cpu-16gb-x86-64 | ||
| timeout-minutes: 45 | ||
| container: | ||
| image: quay.io/libpod/fedora_podman:${{ vars.IMAGE_TAG }} | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - name: fix git safe.directory | ||
| run: git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
| - name: remove pre-installed skopeo package | ||
| run: dnf remove -y skopeo | ||
| - name: build + install | ||
| run: | | ||
| make BUILDTAGS=containers_image_openpgp bin/skopeo | ||
| make BUILDTAGS=containers_image_openpgp install PREFIX=/usr/local | ||
| - run: make BUILDTAGS=containers_image_openpgp validate-docs | ||
|
|
||
| cross: | ||
| needs: [validate, path-filter] | ||
| if: >- | ||
| !contains(github.event.pull_request.title || github.event.head_commit.message, '[CI:DOCS]') | ||
| && (github.event_name != 'pull_request' | ||
| || needs.path-filter.outputs.all == 'true' | ||
| || needs.path-filter.outputs.code == 'true') | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 45 | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||
| with: | ||
| go-version: stable | ||
| - run: make BUILDTAGS=containers_image_openpgp local-cross | ||
|
|
||
| osx: | ||
| needs: [validate, path-filter] | ||
| if: >- | ||
| !contains(github.event.pull_request.title || github.event.head_commit.message, '[CI:DOCS]') | ||
| && (github.event_name != 'pull_request' | ||
| || needs.path-filter.outputs.all == 'true' | ||
| || needs.path-filter.outputs.code == 'true') | ||
| runs-on: macos-latest | ||
| timeout-minutes: 45 | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||
| with: | ||
| go-version: stable | ||
| - name: configure GOPATH (Makefile resolves GOBIN as $(GOPATH)/bin) | ||
| run: | | ||
| GOPATH="$(go env GOPATH)" | ||
| mkdir -p "$GOPATH/bin" | ||
| echo "GOPATH=$GOPATH" >> "$GITHUB_ENV" | ||
| echo "$GOPATH/bin" >> "$GITHUB_PATH" | ||
| - name: brew install gpgme (CGo dep for github.com/proglottis/gpgme) | ||
| run: brew install gpgme | ||
| - run: make tools | ||
| - run: make validate-local test-unit-local bin/skopeo | ||
| - run: ./bin/skopeo -v | ||
|
|
||
| test_skopeo: | ||
| needs: validate | ||
| if: >- | ||
| !contains(github.event.pull_request.title || github.event.head_commit.message, '[CI:DOCS]') | ||
| && !contains(github.event.pull_request.title || github.event.head_commit.message, '[CI:BUILD]') | ||
| runs-on: oracle-vm-2cpu-8gb-x86-64 | ||
| timeout-minutes: 45 | ||
| name: test_skopeo / ${{ matrix.name }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - name: Skopeo Test | ||
| buildtags: "" | ||
| - name: Skopeo Test w/ openpgp | ||
| buildtags: containers_image_openpgp | ||
| - name: Skopeo Test w/ Sequoia | ||
| buildtags: containers_image_sequoia | ||
| container: | ||
| image: quay.io/libpod/skopeo_cidev:${{ vars.IMAGE_TAG }} | ||
| options: --privileged | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - name: fix git safe.directory | ||
| run: git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
| - run: make vendor | ||
| - name: build + install | ||
| run: | | ||
| make "BUILDTAGS=${{ matrix.buildtags }}" bin/skopeo | ||
| make "BUILDTAGS=${{ matrix.buildtags }}" install PREFIX=/usr/local | ||
| - run: make "BUILDTAGS=${{ matrix.buildtags }}" test-unit-local | ||
| - run: make "BUILDTAGS=${{ matrix.buildtags }}" test-integration-local | ||
| - run: make "BUILDTAGS=${{ matrix.buildtags }}" test-system-local | ||
|
|
||
| ostree_rs_ext: | ||
| needs: [validate, path-filter] | ||
| if: >- | ||
| !contains(github.event.pull_request.title || github.event.head_commit.message, '[CI:DOCS]') | ||
| && (github.event_name != 'pull_request' | ||
| || needs.path-filter.outputs.all == 'true' | ||
| || needs.path-filter.outputs.code == 'true') | ||
| runs-on: oracle-vm-4cpu-16gb-x86-64 | ||
| timeout-minutes: 45 | ||
| container: | ||
| image: quay.io/coreos-assembler/fcos-buildroot:testing-devel | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
| - name: fix git safe.directory | ||
| run: git config --global --add safe.directory "$GITHUB_WORKSPACE" | ||
| - name: install rustup stable | ||
| run: | | ||
| dnf remove -y rust | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain stable --profile minimal | ||
| echo "$HOME/.cargo/bin" >> "$GITHUB_PATH" | ||
| - name: build + install skopeo | ||
| run: | | ||
| dnf builddep -y skopeo | ||
| make | ||
| make install | ||
| - name: clone ostree-rs-ext + cargo build | ||
| run: | | ||
| git clone --depth 1 https://github.com/ostreedev/ostree-rs-ext.git /tmp/ostree-rs-ext | ||
| cd /tmp/ostree-rs-ext | ||
| cargo test --no-run | ||
| - name: cargo test | ||
| run: | | ||
| cd /tmp/ostree-rs-ext | ||
| cargo test -- --nocapture --quiet | ||
|
|
||
| # Merge protection is set up for this job name, do not change it. | ||
| success: | ||
| name: "Total Success" | ||
| needs: | ||
| - path-filter | ||
| - validate | ||
| - doccheck | ||
| - cross | ||
| - osx | ||
| - test_skopeo | ||
| - ostree_rs_ext | ||
| if: always() | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| steps: | ||
| - name: Check all required jobs | ||
| run: | | ||
| if [[ "${{ contains(needs.*.result, 'failure') }}" == "true" ]] || \ | ||
| [[ "${{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then | ||
|
Contributor
There was a problem hiding this comment. Non-blocking: I’d slightly prefer an allow-list of success states here. |
||
| echo "One or more required jobs failed or were cancelled" | ||
| exit 1 | ||
| fi | ||
| echo "All required jobs passed or were skipped" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change tests, we definitely do want the test passing before we merge a PR.
(Overall, I’m not sure the path filter is worth the complexity here. There are not that many PRs in this repo, and it’s all fairly small. [It would definitely be useful in container-libs, with the 3 separate modules and many more test jobs.])