Misc modernize fixes#881
Open
kolyshkin wants to merge 5 commits into
Open
Conversation
Suggested by modernize tool. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Generated by modernize. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Suggested by modernize with manual test fixes on top. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
github-actions
Bot
added
storage
mtrmac
requested changes
May 28, 2026
| mergedEntries[i].EndOffset = lastOffset | ||
| for _, entry := range slices.Backward(mergedEntries) { | ||
| if entry.EndOffset == 0 { | ||
| entry.EndOffset = lastOffset |
Contributor
There was a problem hiding this comment.
I don’t think this works, entry is a copy by value.
| lastChunkOffset := entry.EndOffset | ||
| for _, v := range slices.Backward(entry.chunks) { | ||
| v.EndOffset = lastChunkOffset | ||
| v.Size = v.EndOffset - v.Offset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit for details. Mostly generated by
modernize -fixwith some manual fixes on top.