new gha ci with lima#6884
Conversation
Signed-off-by: Tim Zhou <tizhou@redhat.com>
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
not a deep review but LGTM if it passes tests for now, keep in mind something is better than no tests
There was a problem hiding this comment.
For consistency we wanted to use hack/ci everywhere, though I guess not blocking the merge, we can rename afterwards.
nalind
left a comment
nalind
left a comment
There was a problem hiding this comment.
- We exclude integration tests for storage=vfs+priv=rootless along with those for storage=overlay+priv=rootless, so I don't think that leaves us running any integration tests with priv=rootless.
- I don't see where the "in_podman" test runs the test inside of a podman container.
But some is better than none, so we can work on those. LGTM unless we want to fix those first.
|
LGTM in general. I'd like to see @Luap99 's comment cleaned up, and then any further tweaks that you want to make in the short term @timcoding1988 |
| permissions: | ||
| pull-requests: read |
There was a problem hiding this comment.
Is this needed? podman-container-tools/podman#28821 (comment)
There was a problem hiding this comment.
Based on podman-container-tools/podman#28821 (comment) it seems the answer is "no", but we can sort this out in a follow-up.
5 participants
Replaces Cirrus with lima-based GitHub Actions CI. Ported from podman-container-tools/buildah-sandbox#2.