Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/PDOAAC-6302] (issue/137) add in small notificaiton on using -gr flag #179

Merged
merged 10 commits into from
Mar 13, 2025
Merged

[Feature/PDOAAC-6302] (issue/137) add in small notificaiton on using -gr flag #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
13d0f33
add in small notificaiton on using `-gr` flag
hkryeung Mar 5, 2025
cac72b6
adjust location of info
hkryeung Mar 6, 2025
053c298
adjust spacing
hkryeung Mar 6, 2025
cdb4f36
update formatting and wording
hkryeung Mar 6, 2025
c4e1664
formatting
hkryeung Mar 6, 2025
ce06726
formatting season 2
hkryeung Mar 6, 2025
e318d7d
merge in develop
hkryeung Mar 6, 2025
be1943e
updated builds
mike-gangl Mar 12, 2025
43eb7ef
removed 3.12 because it requires a bit more refactoring
mike-gangl Mar 12, 2025
7147633
fixed auth versions
mike-gangl Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/python-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
max-parallel: 2
matrix:
python-version: [ "3.7", "3.8", "3.9", "3.10" ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
poetry-version: [ "1.5.1" ]
os: [ ubuntu-22.04, macos-latest, windows-latest ]
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
fail-fast: false
max-parallel: 1
matrix:
python-version: [ "3.7", "3.8", "3.9", "3.10" ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
poetry-version: [ "1.5.1" ]
os: [ ubuntu-22.04, macos-latest, windows-latest ]
runs-on: ${{ matrix.os }}
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## [Unreleased]
### Added
- Added error messages to inform user if .harmony file is formatted incorrectly or missing a key
- **PODAAC-6302 (issues/137)**
- Added small notification when `-gr` is being used but 0 granules are returned
- Added python versions 3.11 to supported builds
### Fixed
- **PODAAC-6303 (issues/167)**
- Fixed issue where -gr and -sd/-ed (temporal) cannot be used together as a query
### Removed
- Removed python 3.7 from supported builds


## [1.15.2]
### Fixed
Expand Down
7 changes: 7 additions & 0 deletions subscriber/podaac_data_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,13 @@ def cmr_downloader(args, token, data_path):
if args.verbose:
logging.info(str(results['hits']) + " granules found for " + short_name) # noqa E501

if granule is not None and results.get('hits', 0) == 0:
logging.info("** 0 granules found with -gr (granuleUR) flag. **")
logging.info("** If you expected granules to be found and downloaded, **")
logging.info("** please try using wildcards (*/%) in the -gr parameter. **")
logging.info("** -gr=\"*data*\" for multiple characters **")
logging.info("** -gr=\"_A%T_\" for a single character **")

if any([args.dy, args.dydoy, args.dymd]):
file_start_times = pa.parse_start_times(results)
elif args.cycle:
Expand Down
Loading