Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/PODAAC-6303][issue/167] Fixed issue where -gr and -sd/-ed (temporal) cannot be used together as a query #178

Merged
merged 2 commits into from
Mar 6, 2025
Merged

[Feature/PODAAC-6303][issue/167] Fixed issue where -gr and -sd/-ed (temporal) cannot be used together as a query #178

merged 2 commits into from
Mar 6, 2025

Conversation

hkryeung
Copy link

@hkryeung hkryeung commented Mar 5, 2025

  1. Updated the area around "cycles", "granule" and "temporal" to be selective and not "exclusive" (just if and not if else)
  2. Fixed an issue with a unit test: for search-after, using > and != 2000 would mean similar concepts
  3. Added in a unit test for (1)

@hkryeung hkryeung requested a review from mike-gangl March 5, 2025 21:49
@hkryeung hkryeung linked an issue Mar 5, 2025 that may be closed by this pull request
Temporal bounds are ignored when -gr is provided #167
Closed
@hkryeung hkryeung mentioned this pull request Mar 5, 2025
Closed
@hkryeung hkryeung requested a review from yenes56 March 5, 2025 21:51
mike-gangl
mike-gangl approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@mike-gangl mike-gangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. the 3.7 macos isn't working right now- but i think we may want to remove support for python 3.7 and 3.8 regardless. We should add in 3.11, 3.12 and possibly 3.13.

https://devguide.python.org/versions/

@hkryeung hkryeung merged commit c9a4076 into develop Mar 6, 2025
12 of 13 checks passed
@hkryeung hkryeung mentioned this pull request Mar 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-gangl mike-gangl mike-gangl approved these changes

@yenes56 yenes56 Awaiting requested review from yenes56

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporal bounds are ignored when -gr is provided
2 participants
@hkryeung @mike-gangl