fix(agent): support GenericAgent ACP and add setup guide - #442
Closed
Phil-Fan wants to merge 2 commits into
Closed
Conversation
Custom agents previously did not get the cwd shell wrapper, so relative paths in args were resolved against an unspecified process cwd (often / when spawned from the GUI), causing errors like //frontends/xxx.py not found. Include AgentTemplate::Custom in needs_local_cwd_shell_wrap() so custom agents also cd into the vault before exec.
- New guide at docs/usage/genericagent-acp.md covering installation, bridge launch, Agentero custom agent configuration, verification, usage tips and troubleshooting. - Link from docs/usage/index.md and docs/usage/agents.md.
Contributor
Author
|
Closing — the intended upstream PR is for GenericAgent only. Agentero-side notes and the small cwd-shell fix will stay in the fork for local use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables Agentero to connect to GenericAgent via the Agent Client Protocol (ACP), and documents the setup.
GenericAgent ships an experimental ACP stdio bridge (
frontends/genericagent_acp_bridge.py). Agentero's ACP client already supports custom agents, but two issues prevented GenericAgent from working out of the box:argsresolved against an unspecified process cwd (often/when spawned from the GUI), producing errors like//frontends/genericagent_acp_bridge.py: No such file or directory.What changed
AgentTemplate::Custominneeds_local_cwd_shell_wrap()so custom agents are launched through acd <vault-cwd> && exec <command> <args>shell wrapper, matching the existing behavior for the Pi adapter.docs/usage/genericagent-acp.mdwith step-by-step configuration, verification, tips, and troubleshooting; link it fromdocs/usage/index.mdanddocs/usage/agents.md.Related
bf22fefd fix(agent): inject vault cwd into Pi ACP local spawn