Remove delta <= 0 return on chatUpdate#319
Open
MikiProductions wants to merge 1 commit intopo-devs:masterfrom
Open
Remove delta <= 0 return on chatUpdate#319MikiProductions wants to merge 1 commit intopo-devs:masterfrom
MikiProductions wants to merge 1 commit intopo-devs:masterfrom
Conversation
Send Message hangs the sender, maybe this is why
Author
|
I can see that chatUpdate() is only called twice, when the user sends the message and when a channel the user is in receives a message. When the user sends a message (currently) it hangs, this is a bug multiple android v7 users have reported. It unhangs when it is called by the second method (channel message). The only difference I can theorize making the difference between the two times these are called is in the delta evaluation, so I want to try removing that to see if it prevents the hanging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send Message hangs the sender, maybe this is why