Skip to content

docs: rename virtual store to dependency graph store #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jun 28, 2025

No description provided.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jun 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pnpm-io ❌ Failed (Inspect) Jun 28, 2025 0:32am

@zkochan
Copy link
Member Author

zkochan commented Jun 28, 2025

If approved, we can add new options with new names and remove the old names in pnpm v11.

@gluxon
Copy link
Member

gluxon commented Jul 3, 2025

I'm sure there's a bit of context to the rename that I'm not aware of yet. Without that, I think I kind of like the existing "virtual store" name.

It's relatively short and everyone currently knows what it means. While "dependency graph store" might be more accurate, it's longer and less unique.

For example, in macOS, the bottom app bar is called a "Dock". While that's not the perfect name, it's short and everyone is familiar with it. I tend to like short unique names, even if they aren't perfect descriptors. You could imagine an alternate universe where the macOS dock was called "Bottom Application Launcher Bar".

@zkochan
Copy link
Member Author

zkochan commented Jul 4, 2025

The virtual store was kind of an internal thing up until now. I don't remember how I came up with this name. I think maybe I borrowed it from Yarn, which has virtual packages.

Now with the global virtual store feature this store will become more complex and I was wondering if the name of this store should more closely reflect the nature of it. Virtual store is very generic while dependency graph store is reflecting what this store contains.

Of course, it can be named anything as long as the docs explain what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants