Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial lockfile implementation #128

Merged
merged 199 commits into from
Oct 3, 2023
Merged

feat: initial lockfile implementation #128

merged 199 commits into from
Oct 3, 2023

Conversation

KSXGitHub
Copy link
Contributor

Goals:

  • Resolving package version from a lockfile.

Non-goals:

  • Updating the outdated lockfile.
  • Creating new lockfile.
  • Monorepo.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.12     10.7±7.40ms   406.8 KB/sec    1.00      9.5±2.05ms   457.5 KB/sec

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 178 lines in your changes are missing coverage. Please review.

Comparison is base (59a553e) 85.56% compared to head (7318ce8) 86.59%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   85.56%   86.59%   +1.02%     
==========================================
  Files          24       39      +15     
  Lines        1413     2528    +1115     
==========================================
+ Hits         1209     2189     +980     
- Misses        204      339     +135     
Files Coverage Δ
crates/cli/src/commands/add.rs 96.26% <100.00%> (+0.05%) ⬆️
crates/cli/src/package_manager.rs 95.23% <100.00%> (+11.90%) ⬆️
crates/lockfile/src/dependency_path.rs 100.00% <100.00%> (ø)
crates/lockfile/src/lib.rs 0.00% <ø> (ø)
crates/lockfile/src/lockfile_version.rs 100.00% <100.00%> (ø)
crates/lockfile/src/multi_project_snapshot.rs 100.00% <100.00%> (ø)
crates/lockfile/src/package_snapshot_dependency.rs 100.00% <100.00%> (ø)
crates/lockfile/src/pkg_name_ver.rs 100.00% <100.00%> (ø)
crates/lockfile/src/pkg_name_ver_peer.rs 100.00% <100.00%> (ø)
crates/lockfile/src/pkg_ver_peer.rs 100.00% <100.00%> (ø)
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSXGitHub KSXGitHub marked this pull request as ready for review October 3, 2023 06:21
@KSXGitHub KSXGitHub requested review from zkochan and anonrig October 3, 2023 06:28
README.md Outdated Show resolved Hide resolved
crates/cli/src/package.rs Outdated Show resolved Hide resolved
crates/cli/src/package.rs Show resolved Hide resolved
@anonrig anonrig merged commit 276915b into main Oct 3, 2023
16 of 17 checks passed
@anonrig anonrig deleted the lockfile branch October 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants