Updated visibility of controls in the ControlsTest web part #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @GuidoZam - thank you for the PR! |
|
Hi @GuidoZam, I just noticed your PR regarding controls visibility. I already pushed update for the whole testing web part without noticing your proposal, really sorry about that 🫤 Feel free to update the PR with other improvments if you found some or to close it otherwise. As an improvment idea, I was thinking about adding new property pane options for each control, so that you can better test each one of them without going back and forth in the code to manually update values. If you'd like to submit something regarding this, please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This pull request is to fix the display of the ListItemAttachments control in the ControlsTest web part.
The web part was always showing the ListItemAttachments control, now it can be displayed or hide as all the other controls.