Skip to content

Fixes entra m365group remove command. Closes #7054 #7063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adam-it wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes entra m365group remove command. Closes #7054 #7063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/m365/entra/commands/m365group/m365group-remove.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe(commands.M365GROUP_REMOVE, () => {

const defaultPostStub = (): sinon.SinonStub => {
return sinon.stub(request, 'post').callsFake(async (opts) => {
if (opts.url === `https://contoso-admin.sharepoint.com/_api/GroupSiteManager/Delete?siteUrl='https://contoso.sharepoint.com/teams/sales'`) {
if (opts.url === `https://contoso-admin.sharepoint.com/_api/GroupSiteManager/Delete?siteUrl='https%3A%2F%2Fcontoso.sharepoint.com%2Fteams%2Fsales'`) {
return Promise.resolve({
"data": {
"odata.null": true
Expand Down Expand Up @@ -247,7 +247,7 @@ describe(commands.M365GROUP_REMOVE, () => {
.onSecondCall().resolves({ id: groupId });

sinon.stub(request, 'post').callsFake(async (opts) => {
if (opts.url === `https://contoso-admin.sharepoint.com/_api/GroupSiteManager/Delete?siteUrl='https://contoso.sharepoint.com/teams/sales'`) {
if (opts.url === `https://contoso-admin.sharepoint.com/_api/GroupSiteManager/Delete?siteUrl='https%3A%2F%2Fcontoso.sharepoint.com%2Fteams%2Fsales'`) {
return Promise.resolve({
"data": {
"odata.null": true
Expand Down
4 changes: 2 additions & 2 deletions src/m365/entra/commands/m365group/m365group-remove.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ class EntraM365GroupRemoveCommand extends GraphCommand {
}

const requestOptions: CliRequestOptions = {
url: `${spoAdminUrl}/_api/GroupSiteManager/Delete?siteUrl='${url}'`,
url: `${spoAdminUrl}/_api/GroupSiteManager/Delete?siteUrl='${formatting.encodeQueryParameter(url)}'`,
headers: {
accept: 'application/json;odata=nometadata'
},
Expand Down Expand Up @@ -254,4 +254,4 @@ class EntraM365GroupRemoveCommand extends GraphCommand {
}
}

export default new EntraM365GroupRemoveCommand();
export default new EntraM365GroupRemoveCommand();