-
Notifications
You must be signed in to change notification settings - Fork 370
New command: spo brandcenter settings list. Closes #6653 #7058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a new command spo brandcenter settings list to retrieve SharePoint Brand Center configuration settings. The implementation follows the established patterns for SPO commands that accept only global options, using the Zod schema validation approach.
- Adds a new SPO command to list Brand Center configuration
- Includes comprehensive test coverage with schema validation tests
- Provides complete documentation with examples and response formats in multiple output types
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/spo/commands/brandcenter/brandcenter-settings-list.ts | Main command implementation that fetches Brand Center configuration via SharePoint REST API |
| src/m365/spo/commands/brandcenter/brandcenter-settings-list.spec.ts | Comprehensive test suite covering validation, success scenarios, and error handling |
| src/m365/spo/commands.ts | Registers the new BRANDCENTER_SETTINGS_LIST command constant |
| docs/src/config/sidebars.ts | Adds the new command to the documentation sidebar under brandcenter category |
| docs/docs/cmd/spo/brandcenter/brandcenter-settings-list.mdx | Complete documentation including usage, permissions, examples, and response formats |
| .devproxy/api-specs/sharepoint.yaml | Adds API specification for the Brand Center Configuration endpoint with security requirements |
src/m365/spo/commands/brandcenter/brandcenter-settings-list.spec.ts
Outdated
Show resolved
Hide resolved
|
|
||
| ## Examples | ||
|
|
||
| List all brand center config |
Copilot
AI
Dec 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The example description uses the abbreviation "config" instead of the full word "configuration" used in the command description. For consistency, consider using "Lists the brand center configuration" or "Retrieve the brand center configuration".
| List all brand center config | |
| List all brand center configuration |
src/m365/spo/commands/brandcenter/brandcenter-settings-list.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/spo/commands/brandcenter/brandcenter-settings-list.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/spo/commands/brandcenter/brandcenter-settings-list.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/spo/commands/brandcenter/brandcenter-settings-list.spec.ts
Outdated
Show resolved
Hide resolved
c3e8745 to
856edfe
Compare
|
Thanks! We'll try to review it soon. |
Closes #6653