-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft:Feature/constraints check #164
base: develop
Are you sure you want to change the base?
Conversation
…ine remaining, but the solution looks good.
…, updated generator cost function reading
…rrect generator outputs
- Use nlp_scaling_method gradient based - Use -inf as lower bound for line flow constraints
- Have the angle variables unconstrained. - Some experimentation with setting limits for generator bus voltages. Reverted for now.
…verted it with commented out code.
I suggest merging #163 before this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran tests for this branch on AMD EPYC/MI250X machine, and I saw following tests fail:
19/60 Test #19: FUNCTIONALITY_TEST_OPFLOW_RAJAHIOP_SPARSE_GPU_TOML_TESTSUITE .................***Failed 1.44 sec
Start 20: FUNCTIONALITY_TEST_OPFLOW_IPOPT_POLAR_TOML_TESTSUITE
20/60 Test #20: FUNCTIONALITY_TEST_OPFLOW_IPOPT_POLAR_TOML_TESTSUITE .........................***Failed 5.60 sec
Start 21: OPFLOW_MONITOR_KVLEVEL_IPOPT
21/60 Test #21: OPFLOW_MONITOR_KVLEVEL_IPOPT ................................................. Passed 1.36 sec
Start 22: OPFLOW_LINEFLOW_PENALTY
22/60 Test #22: OPFLOW_LINEFLOW_PENALTY ......................................................***Failed 1.48 sec
Also, test FUNCTIONALITY_TEST_SCOPFLOW_HIOP_TESTSUITE
. It seems it never leaves HiOp PriDec main loop.
@abhyshr, do you see all tests pass when you run them on your machine(s)?
The good news is there is only one test that hangs. The bad news is there are a few more other tests that fail:
@abhyshr, do these tests pass on other machines? |
Looking at the output logs of some of these tests, it seems they are failing because of mismatched number of iterations to converged solution. This is probably not the best metric to use if the number of the iterations is >100. |
Merge request type
Relates to
This MR updates
Summary