Use ISO standard attributes #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the compiler specific code in favour of the newly standardized __has_c_attribute. This is supported in the principle compilers (gcc, clang, vc) and, now that it is standard, should be supported in other compilers too, for example icc and, presumably if they are maintained, Watcom and Borland. Passes multiple tests with gcc and clang including cross-compilation with gcc. Signed-off-by: John Bowler <[email protected]>
GCC issues warnings for unsupported attributes and quite possibly other compilers do too. This changes the pngconf.h implementation to explicitly check for each attribute when defining a macro based on it. Signed-off-by: John Bowler <[email protected]>
|
Merge conflict disaster area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the compiler specific code in favour of the newly
standardized __has_c_attribute. This is supported in the principle
compilers (gcc, clang, vc) and, now that it is standard, should be
supported in other compilers too, for example icc and, presumably if
they are maintained, Watcom and Borland.
Passes multiple tests with gcc and clang including cross-compilation
with gcc.
Signed-off-by: John Bowler [email protected]