Skip to content

fix(polymarket-us): prevent websocket connect hangs with garbage-collected timeout #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 2 commits into from
Jul 10, 2026
Merged

fix(polymarket-us): prevent websocket connect hangs with garbage-collected timeout #1580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e4657
fix(polymarket-us): prevent websocket connect hangs with garbage-coll…
AbhilashG12 Jul 9, 2026
9dc8fed
fix: remove trailing whitespace in polymarket us websocket
realfishsam Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion core/src/exchanges/polymarket_us/websocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,24 @@ export class PolymarketUSWebSocket {
socket.on('trade', (msg: SdkTrade) => this.handleTrade(msg));
socket.on('error', (err: Error) => this.handleError(err));
socket.on('close', () => this.handleClose());
await socket.connect();
// Wrap connection in a timeout with proper garbage collection
const CONNECTION_TIMEOUT_MS = 15000; // 15s is standard for trading API handshakes
let timeoutHandle: NodeJS.Timeout;

const timeoutPromise = new Promise<never>((_, reject) => {
timeoutHandle = setTimeout(() => {
reject(new Error(`PolymarketUS WebSocket connection timed out after ${CONNECTION_TIMEOUT_MS}ms`));
}, CONNECTION_TIMEOUT_MS);
});

try {
await Promise.race([
socket.connect(),
timeoutPromise
]);
} finally {
clearTimeout(timeoutHandle!); // Always clear the timer so the event loop can breathe
}
this.socket = socket;
})();

Expand Down
Loading