Quick bugfix to Flycontrols #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, I'll 100% admit I don't fully understand this code (apologies). However, repeated bug under use of Flycontrols with dragToLook = true, that it would get "stuck" as if the mouse was always down. This happened with some condition where mouseStatus ended up > 1 and never got back to 0. This two line fix seems to fix it. Been testing it locally and works well. Feedback welcome!
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@CodyJasonBennett Sorry for the random ping but I was hoping you could let me know how to get someone to take a look at this PR (saw you were in this repo not so long ago). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I'll 100% admit I don't fully understand this code (apologies). However, repeated bug under use of Flycontrols with dragToLook = true, that it would get "stuck" as if the mouse was always down. This happened with some condition where mouseStatus ended up > 1 and never got back to 0.
This two line fix seems to fix it. Been testing it locally and works well.
Feedback welcome!
Why
Small but very annoying bug in Flycontrols where after extensive use, the mouse gets "stuck" as if down. This only happens with dragToLook=true.
Note - feeling like a dolt but could not find CONTRIBUTING.md!
What
Two line fix - rather than increment/decrement mouseStatus, just set to 0 or 1. This avoids mouseStatus becoming > 1 and then never decrementing back to 0.
Checklist