Skip to content

Conversation

ynamite
Copy link

@ynamite ynamite commented Oct 4, 2024

get current canvas output size and set composer size to this. Required to work with Drei's View.tsx, see #285

get current canvas output size and set composer size to this. Required to work with Drei's View.tsx, see
@ynamite ynamite changed the title Update EffectComposer.tsx with current canvas output size fix: set composer size to current canvas output size Oct 4, 2024
@ynamite ynamite closed this by deleting the head repository Mar 1, 2025
@mcu13321
Copy link

@ynamite Why was this PR closed? I noticed that when using EffectComposer inside View, the canvas does not update to the correct size when I resize the browser window (e.g. by clicking the maximize/restore button). At first, I thought it was an R3F issue, but when I commented out the EffectComposer in View, the canvas updated correctly.

I found this issue and I believe this PR could solve my problem, but I saw that it was closed. Could you please share the reason why?

@ynamite
Copy link
Author

ynamite commented Aug 20, 2025

@mcu13321 strange, I don‘t recall deleting the repository. May have been a mistake on my part. But it was just a few added lines of code anyway.

I loosely recall someone else having made a similar pull request that was closed by the maintainers. That may have been my rationale for deleting it, but not sure.

@mcu13321
Copy link

Yes, by adding the code from this PR, I was able to solve the issue. The solution works, but I’m not sure why it wasn’t merged.

@ynamite
Copy link
Author

ynamite commented Aug 26, 2025

@mcu13321 sorry I was on vacation for a couple of days. Are you open to creating a PR yourself?

@mcu13321
Copy link

mcu13321 commented Aug 27, 2025

I’ve submitted the PR and hope it can be approved. #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants