fix: should update dependents with the value of the unwrapped atom when the promise resolves #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
Size Change: -142 B (-0.15%) Total Size: 91.7 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/HC9APKNXQ |
See documentations for usage instructions.
dmaskasky
force-pushed
the
fix-unwrap-atomEffect
branch
from
f4e7433 to
31df90f
Compare
dmaskasky
force-pushed
the
fix-unwrap-atomEffect
branch
from
31df90f to
66a134a
Compare
…hen the promise resolves
dmaskasky
force-pushed
the
fix-unwrap-atomEffect
branch
from
66a134a to
fc05691
Compare
dmaskasky
force-pushed
the
fix-unwrap-atomEffect
branch
from
b060677 to
c827397
Compare
dmaskasky
force-pushed
the
fix-unwrap-atomEffect
branch
from
c827397 to
7addd25
Compare
dai-shi
reviewed
Jan 9, 2025
Comment on lines
+154
to
+166
| it('should update dependents with the value of the unwrapped atom when the promise resolves', async () => { | ||
| const store = createStore() | ||
| const asyncTarget = atom(() => Promise.resolve('value')) | ||
| const target = unwrap(asyncTarget) | ||
| const results: string[] = [] | ||
| const derived = atom(async (get) => { | ||
| await Promise.resolve() | ||
| results.push('effect ' + get(target)) | ||
| }) | ||
| store.sub(derived, () => {}) | ||
| await new Promise((r) => setTimeout(r)) | ||
| expect(results).toEqual(['effect undefined', 'effect value']) | ||
| }) |
There was a problem hiding this comment.
Looks good. So, it's a regression, right? My bad... I'll see what I can do with the impl. It will be step by step and take a bit of time. Sorry folks for waiting.
|
|
|
I change my mind. Let me use this branch, which is easier for me to push changes. |
Open
1 task
dai-shi
reviewed
Jan 16, 2025
| @@ -94,7 +94,7 @@ it('correctly handles the same promise being returned twice from an atom getter | |||
| await expect(store.get(derivedAtom)).resolves.toBe('Asynchronous Data') | |||
| }) | |||
|
|
|||
| it('keeps atoms mounted between recalculations', async () => { | |||
| it('keeps sync atoms mounted between recalculations', async () => { | |||
There was a problem hiding this comment.
This is the planned breaking change in v2.12.0.
@yuneco Will you be able to check if this breaks your app?
npm i https://pkg.csb.dev/pmndrs/jotai/commit/b4bb8a8d/jotai
|
Split to #2940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
#2914
Summary
Caused by 34b4f8e and e777f46
Fix
Implementation
atomState.m.q is a Set of all atoms added async. Atoms added async with getter in readAtomState are added to this set. This Set is cleared when a new atom value is set and after recomputeDependents has completed. Only unmount dependencies not present in this Set.
Example:
Check List
pnpm run fix:formatfor formatting code and docs