[INTERNAL] Add batch to listeners #2887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/7U4BKGCNE |
See documentations for usage instructions.
dai-shi
requested changes
Dec 23, 2024
| @@ -198,9 +200,12 @@ const registerBatchAtom = ( | |||
| ) => { | |||
| if (!batch.D.has(atom)) { | |||
| batch.D.set(atom, new Set()) | |||
| addBatchFunc(batch, 'M', () => { | |||
| atomState.m?.l.forEach((listener) => addBatchFunc(batch, 'M', listener)) | |||
There was a problem hiding this comment.
I would like to avoid this hack too.
| @@ -503,7 +508,7 @@ const buildStore = ( | |||
|
|
|||
| // Step 2: use the topSortedReversed atom list to recompute all affected atoms | |||
| // Track what's changed, so that we can short circuit when possible | |||
| addBatchFunc(batch, 'H', () => { | |||
| const finishRecompute = () => { | |||
There was a problem hiding this comment.
Though increasing bundle size, this is more readable.
| @@ -645,14 +651,15 @@ const buildStore = ( | |||
| isSync = false | |||
| } | |||
| } | |||
| addBatchFunc(batch, 'L', () => { | |||
| const processOnMount = () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does not change API or behavior.
Check List
pnpm run prettierfor formatting code and docs