Benchmarks

[L-Qun]

Summary

I think benchmarks are really important; we also have a lot of them in the source code. However, we need a workflow to check every PR for any potential performance degradation.

Check List

• pnpm run prettier for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 13, 2024 4:20pm

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[github-actions]

Preview in LiveCodes

Latest commit: bb07658
Last updated: Jul 13, 2024 4:20pm (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/DZRS9N2BJ

---

See documentations for usage instructions.

[L-Qun]

@dai-shi It seems we need to config the jotai repo, can you help to take a look at this issue?

[dai-shi]

Hi, thanks for your suggestion.

I agree that benchmarks are important, but the one we have now is very specific and doesn't cover real use cases. I don't see much benefit of adding a workflow with it.
That said, it would be nice if you create some benchmark suites. I actually think we can drop what we have now.

I don't think a workflow has a permission to write a comment from a forked repo. This happens with compressed-size-action.yml too. Anyway, the workflow isn't very important. The benchmark itself would be important.

[L-Qun]

Hi, thanks for your suggestion.

I agree that benchmarks are important, but the one we have now is very specific and doesn't cover real use cases. I don't see much benefit of adding a workflow with it. That said, it would be nice if you create some benchmark suites. I actually think we can drop what we have now.

I don't think a workflow has a permission to write a comment from a forked repo. This happens with compressed-size-action.yml too. Anyway, the workflow isn't very important. The benchmark itself would be important.

Got it thanks for your reply