-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): add description for the RESET symbol. #2307
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0afa305:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion.
Does this work for you?
7e9b0e9
to
1670f71
Compare
This improves debugging as the symbol no longer appears anonymous in logs.
Co-authored-by: Daishi Kato <[email protected]>
5be0167
to
371ec3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and hope this helps you to develop Jotai libraries!
Hi @dai-shi, Error: src/components/trip/utils.tsx(30,17): error TS2339: Property 'disabled' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'disabled' does not exist on type 'unique symbol'.
Error: src/components/trip/utils.tsx(56,17): error TS2339: Property 'data' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'data' does not exist on type 'unique symbol'.
Error: src/components/trip/utils.tsx(57,17): error TS2339: Property 'formData' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'formData' does not exist on type 'unique symbol'.
Error: src/components/trip/utils.tsx(58,17): error TS2339: Property 'formData' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'formData' does not exist on type 'unique symbol'.
Error: src/forms/withForm.tsx(26,11): error TS2345: Argument of type '(draft: WritableDraft<FormState>) => void' is not assignable to parameter of type 'unique symbol | FormState | ((draft: unique symbol | WritableDraft<FormState>) => void)'.
Type '(draft: WritableDraft<FormState>) => void' is not assignable to type '(draft: unique symbol | WritableDraft<FormState>) => void'.
Types of parameters 'draft' and 'draft' are incompatible.
Type 'unique symbol | WritableDraft<FormState>' is not assignable to type 'WritableDraft<FormState>'.
Type 'typeof import("/home/runner/work/saladin-admin/saladin-admin/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/jotai/esm/vanilla/utils/constants").RESET' is not assignable to type 'WritableDraft<FormState>'.
Error: src/forms/withForm.tsx(28,21): error TS2339: Property 'data' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'data' does not exist on type 'unique symbol'.
Error: src/forms/withForm.tsx(29,21): error TS2339: Property 'formData' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'formData' does not exist on type 'unique symbol'.
Error: src/routes/offline/OfflineOrder.tsx(179,12): error TS2339: Property 'edit' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'edit' does not exist on type 'unique symbol'.
Error: src/routes/offline/OfflineOrder.tsx(180,12): error TS2339: Property 'open' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'open' does not exist on type 'unique symbol'.
Error: src/routes/trip/TripClaim.tsx([134](https://github.com/tenxtenx/saladin-admin/actions/runs/7437390375/job/20234961320?pr=1123#step:8:135),12): error TS2339: Property 'edit' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'edit' does not exist on type 'unique symbol'.
Error: src/routes/trip/TripClaim.tsx([135](https://github.com/tenxtenx/saladin-admin/actions/runs/7437390375/job/20234961320?pr=1123#step:8:136),12): error TS2339: Property 'open' does not exist on type 'unique symbol | WritableDraft<FormState>'.
Property 'open' does not exist on type 'unique symbol'.
Error: Process completed with exit code 2. |
Are you sure if this is the cause? I wonder if it's #2304. In any case, creating a reproduction with https://www.typescriptlang.org/play would be very helpful. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jotai](https://togithub.com/pmndrs/jotai) | [`^2.6.0` -> `^2.6.4`](https://renovatebot.com/diffs/npm/jotai/2.6.0/2.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/jotai/2.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/jotai/2.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/jotai/2.6.0/2.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/jotai/2.6.0/2.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/jotai (jotai)</summary> ### [`v2.6.4`](https://togithub.com/pmndrs/jotai/releases/tag/v2.6.4) [Compare Source](https://togithub.com/pmndrs/jotai/compare/v2.6.3...v2.6.4) Performance improvement! Check it out! ##### What's Changed - refactor: refactoring store and options type by [@​ssi02014](https://togithub.com/ssi02014) in [https://github.com/pmndrs/jotai/pull/2360](https://togithub.com/pmndrs/jotai/pull/2360) - refactor: modified Args type by [@​ssi02014](https://togithub.com/ssi02014) in [https://github.com/pmndrs/jotai/pull/2367](https://togithub.com/pmndrs/jotai/pull/2367) - Improve performance of recomputeDependents by [@​samkline](https://togithub.com/samkline) in [https://github.com/pmndrs/jotai/pull/2363](https://togithub.com/pmndrs/jotai/pull/2363) - fix(vanilla): fix unexpected cache in jotai-scope by [@​yf-yang](https://togithub.com/yf-yang) in [https://github.com/pmndrs/jotai/pull/2371](https://togithub.com/pmndrs/jotai/pull/2371) ##### New Contributors - [@​ssi02014](https://togithub.com/ssi02014) made their first contribution in [https://github.com/pmndrs/jotai/pull/2360](https://togithub.com/pmndrs/jotai/pull/2360) - [@​samkline](https://togithub.com/samkline) made their first contribution in [https://github.com/pmndrs/jotai/pull/2363](https://togithub.com/pmndrs/jotai/pull/2363) - [@​yf-yang](https://togithub.com/yf-yang) made their first contribution in [https://github.com/pmndrs/jotai/pull/2371](https://togithub.com/pmndrs/jotai/pull/2371) **Full Changelog**: pmndrs/jotai@v2.6.3...v2.6.4 ### [`v2.6.3`](https://togithub.com/pmndrs/jotai/releases/tag/v2.6.3) [Compare Source](https://togithub.com/pmndrs/jotai/compare/v2.6.2...v2.6.3) Some improvements in core and utils 👏 #### What's Changed - fix: atoms should not remount on recalculations (with async dependencies) by [@​dmaskasky](https://togithub.com/dmaskasky) in [https://github.com/pmndrs/jotai/pull/2347](https://togithub.com/pmndrs/jotai/pull/2347) - fix(utils): atomWithReducer for jotai-scope by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2351](https://togithub.com/pmndrs/jotai/pull/2351) - fix(utils/atomWithStorage): defaultStorage with disabled local storage crashes on mount by [@​benediktschlager](https://togithub.com/benediktschlager) in [https://github.com/pmndrs/jotai/pull/2354](https://togithub.com/pmndrs/jotai/pull/2354) - feat(vanilla): customizable atom.unstable_is by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2356](https://togithub.com/pmndrs/jotai/pull/2356) #### New Contributors - [@​SpringHgui](https://togithub.com/SpringHgui) made their first contribution in [https://github.com/pmndrs/jotai/pull/2320](https://togithub.com/pmndrs/jotai/pull/2320) - [@​sakurawen](https://togithub.com/sakurawen) made their first contribution in [https://github.com/pmndrs/jotai/pull/2358](https://togithub.com/pmndrs/jotai/pull/2358) - [@​JoltCode](https://togithub.com/JoltCode) made their first contribution in [https://github.com/pmndrs/jotai/pull/2357](https://togithub.com/pmndrs/jotai/pull/2357) - [@​benediktschlager](https://togithub.com/benediktschlager) made their first contribution in [https://github.com/pmndrs/jotai/pull/2354](https://togithub.com/pmndrs/jotai/pull/2354) **Full Changelog**: pmndrs/jotai@v2.6.2...v2.6.3 ### [`v2.6.2`](https://togithub.com/pmndrs/jotai/releases/tag/v2.6.2) [Compare Source](https://togithub.com/pmndrs/jotai/compare/v2.6.1...v2.6.2) Some improvements for atomWithStorage. Feedback is welcome. #### What's Changed - fix(vanilla): should mount once with atom creator atom by [@​nogaten](https://togithub.com/nogaten) in [https://github.com/pmndrs/jotai/pull/2319](https://togithub.com/pmndrs/jotai/pull/2319) - feat(utils): createJSONStrage options by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2324](https://togithub.com/pmndrs/jotai/pull/2324) - feat(utils): add withStorageValidator by [@​dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/jotai/pull/2336](https://togithub.com/pmndrs/jotai/pull/2336) #### New Contributors - [@​L-Qun](https://togithub.com/L-Qun) made their first contribution in [https://github.com/pmndrs/jotai/pull/2318](https://togithub.com/pmndrs/jotai/pull/2318) - [@​ahme-dev](https://togithub.com/ahme-dev) made their first contribution in [https://github.com/pmndrs/jotai/pull/2332](https://togithub.com/pmndrs/jotai/pull/2332) - [@​nogaten](https://togithub.com/nogaten) made their first contribution in [https://github.com/pmndrs/jotai/pull/2319](https://togithub.com/pmndrs/jotai/pull/2319) **Full Changelog**: pmndrs/jotai@v2.6.1...v2.6.2 ### [`v2.6.1`](https://togithub.com/pmndrs/jotai/releases/tag/v2.6.1) [Compare Source](https://togithub.com/pmndrs/jotai/compare/v2.6.0...v2.6.1) This version has two minor improvements for library authors. It's wonderful to see Jotai ecosystem growing. No major bugs have been reported lately. It's fairly okay to say the current version is pretty stable. #### What's Changed - fix(utils): add init property to the return type of atomWithReset by [@​jaesoekjjang](https://togithub.com/jaesoekjjang) in [https://github.com/pmndrs/jotai/pull/2304](https://togithub.com/pmndrs/jotai/pull/2304) - fix(utils): add description for the RESET symbol. by [@​MiroslavPetrik](https://togithub.com/MiroslavPetrik) in [https://github.com/pmndrs/jotai/pull/2307](https://togithub.com/pmndrs/jotai/pull/2307) #### New Contributors - [@​wherehows](https://togithub.com/wherehows) made their first contribution in [https://github.com/pmndrs/jotai/pull/2270](https://togithub.com/pmndrs/jotai/pull/2270) - [@​benson00077](https://togithub.com/benson00077) made their first contribution in [https://github.com/pmndrs/jotai/pull/2284](https://togithub.com/pmndrs/jotai/pull/2284) - [@​ioExpander](https://togithub.com/ioExpander) made their first contribution in [https://github.com/pmndrs/jotai/pull/2280](https://togithub.com/pmndrs/jotai/pull/2280) - [@​jaesoekjjang](https://togithub.com/jaesoekjjang) made their first contribution in [https://github.com/pmndrs/jotai/pull/2304](https://togithub.com/pmndrs/jotai/pull/2304) **Full Changelog**: pmndrs/jotai@v2.6.0...v2.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/likec4/likec4). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This improves debugging as the symbol no longer appears anonymous in logs.
Related Issues or Discussions
#2306
Fixes #
Summary
Check List
yarn run prettier
for formatting code and docs