Merged
Conversation
This is a combination of 28 commits.
THIS BRANCH NEEDS MULTI-RELEASE JAR
oowekyala
added
the
needs-ux-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it now handles nearly everything (except examples), it also exports properties. It depends on a small library I made outside of here.
The PR also fixes some performance issues (sometimes causing a freeze and crash of the app) caused by the inefficient implementation of the stuff to count unread event notifications. The library provides an efficient implementation, which at some point I'd like to move into ReactFX (TomasMikula/ReactFX#72)