Skip to content

fix: integrate DOMPurify to sanitize innerHTML assignments in dashboard #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pm7y merged 7 commits into from
Jan 2, 2026
Merged

fix: integrate DOMPurify to sanitize innerHTML assignments in dashboard #252

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
593f64c
Initial plan
Copilot Jan 2, 2026
7f3a507
fix: integrate DOMPurify for XSS protection in dashboard
Copilot Jan 2, 2026
9f27dfa
fix: add DOMPurify sanitization to event and rejection list innerHTML…
Copilot Jan 2, 2026
589a82b
fix: upgrade DOMPurify to v3.3.1 and add SRI hash for CDN security
Copilot Jan 2, 2026
53d37de
fix: correct DOMPurify 3.3.1 SRI hash to resolve browser blocking
Copilot Jan 2, 2026
42b6498
fix: switch to cdnjs CDN for DOMPurify 3.2.7 with verified SRI hash
Copilot Jan 2, 2026
2987798
fix: Format and fix SRI
pm7y Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/AzureEventGridSimulator/Dashboard/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@
selectedEventId = null;
selectedRejectionId = null;
elements.detailPanel.classList.remove('open');
elements.detailContent.innerHTML = '<p class="detail-placeholder">Select an event to view details</p>';
elements.detailContent.innerHTML = DOMPurify.sanitize('<p class="detail-placeholder">Select an event to view details</p>');
renderEventsList();
renderRejectionsList();
}
Expand Down Expand Up @@ -447,7 +447,7 @@
${renderDeliverySection(event.deliveries || [])}
`;

elements.detailContent.innerHTML = html;
elements.detailContent.innerHTML = DOMPurify.sanitize(html);

// Attach attempt toggle handlers
elements.detailContent.querySelectorAll('.attempt-toggle').forEach(toggle => {
Expand Down Expand Up @@ -505,7 +505,7 @@
` : ''}
`;

elements.detailContent.innerHTML = html;
elements.detailContent.innerHTML = DOMPurify.sanitize(html);
}

function renderDeliverySection(deliveries) {
Expand Down
1 change: 1 addition & 0 deletions src/AzureEventGridSimulator/Dashboard/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ <h3>Event Details</h3>
</aside>
</main>

<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/purify.min.js"></script>
<script src="/dashboard/app.js"></script>
</body>
</html>
Loading