fix: Build Race Condition #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses build race conditions by adding the /m:1 MSBuild flag to disable parallel builds across all CI/CD workflows. While this resolves the race condition, it comes at the cost of significantly increased build times by forcing single-threaded compilation.
Key Changes:
- Added
/m:1flag to alldotnet buildcommands in CI/CD workflows - Applied consistently across release.yml, ci.yml, and codeql.yml workflows
- Affects all platform builds (Windows, Linux, macOS)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Added /m:1 flag to the multi-platform release build step to disable parallel compilation |
| .github/workflows/ci.yml | Added /m:1 flag to both main project and test project build steps in the CI workflow |
| .github/workflows/codeql.yml | Added /m:1 flag to the security analysis build step |
pm7y
force-pushed
the
fix-race-condition
branch
from
be054d8 to
342faa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.