fix build error on latest gcc and linux, gets is deprecated, and raspberry pi build of scons. add mac build of scons #18
Conversation
|
@stonewell Thanks for opening this PR. Could you please fill up the Individual Contribution License Agreement before I can approve to merging this PR? Thanks! |
|
signed |
| 'cygwin' : 'x86-unknown-cygwin', | ||
| 'darwin' : 'universal-apple-macosx' | ||
| 'darwin' : 'universal-apple-macosx', | ||
| 'raspberry-pi-arm' : 'arm-raspberry-pi-linux' |
There was a problem hiding this comment.
nit: Could you align the : please?
| platform_id = sys.platform | ||
| if platform.system() == 'Linux': | ||
| if (platform.machine() == 'i386' or | ||
| if pi_version() is not None: |
There was a problem hiding this comment.
Is there any way to hook into platform.machine().startswith('arm') last and differentiate between linux-arm and raspberry-pi-arm instead?
Alternatively, is there anyway to use linux-arm for raspberry?
| @@ -0,0 +1,5 @@ | |||
| LoadTool('gcc-generic', env) | |||
There was a problem hiding this comment.
This is intentionally not supported because building iOS/macOS with Scons is unstable and unsupported at the moment.
| NPT_CHECK_SEVERE(service->GetStateVariableValue("AVTransportURI", curURI)); | ||
| NPT_CHECK_SEVERE(service->GetStateVariableValue("AVTransportURIMetaData", metaData)); | ||
|
|
||
| service->SetStateVariable("TransportState", "PLAYING"); |
There was a problem hiding this comment.
I don't think you want this to set the state, it should be your delegate depending if it accepts to play that should update the service.
| PLT_Service* service; | ||
| NPT_CHECK_SEVERE(m_Renderer->FindServiceByType("urn:schemas-upnp-org:service:AVTransport:1", service)); | ||
|
|
||
| service->SetStateVariable("TransportState", "PLAYING"); |
There was a problem hiding this comment.
Same here, I think your delegate should be doing that or maybe do it only if the delegate method returned success.
2 participants
No description provided.