Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1198 #1200

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix for issue 1198 #1200

merged 1 commit into from
Feb 18, 2025

Conversation

gtribello
Copy link
Member

Description

This is a fix for issue #1198

The reference to the Keywords object is Action is only valid during construction. The underlying object is destroyed after the constructor is finished, so the reference to Keywords is no longer accessible. The keywords.exists("NO_ACTION_LOG") is thus not available if you call error during calculate. If I just remove that if statement it all works fine.

Target release

I would like my code to appear in release 2.10

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@carlocamilloni carlocamilloni merged commit f128d50 into v2.10 Feb 18, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants