Fixed a missing fclose

(to be backported as a fix)
plumed · Mar 9, 2023 · edb0587 · edb0587 · PlumedBot · Mar 9, 2023
1 parent f5110df
commit edb0587
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/mapping/PathTools.cpp b/src/mapping/PathTools.cpp
@@ -144,8 +144,11 @@ int PathTools::main(FILE* in, FILE*out,Communicator& pc) {
   std::string ofmt; parse("--arg-fmt",ofmt);
   std::string ofilename; parse("--out",ofilename);
   if( ifilename.length()>0 ) {
-    fprintf(out,"Reparameterising path in file named %s so that all frames are equally spaced \n",ifilename.c_str() );
-    FILE* fp=fopen(ifilename.c_str(),"r");
+    std::fprintf(out,"Reparameterising path in file named %s so that all frames are equally spaced \n",ifilename.c_str() );
+    FILE* fp=std::fopen(ifilename.c_str(),"r");
+// call fclose when fp goes out of scope
+    auto deleter=[](FILE* f) { if(f) std::fclose(f); };
+    std::unique_ptr<FILE,decltype(deleter)> fp_deleter(fp,deleter);
     bool do_read=true; std::vector<std::unique_ptr<ReferenceConfiguration>> frames;
     while (do_read) {
       PDB mypdb;