established PlumeMeshUtils.py#116
Draft
andytorrestb wants to merge 5 commits into
Draft
Conversation
andytorrestb
commented
Sep 29, 2025
Member
Author
andytorrestb
left a comment
andytorrestb
left a comment
There was a problem hiding this comment.
These are most likely better defined at the Vehicle level. Please move to the Vehicle class and manually trace through errors to ensure no test cases are broken.
Member
Author
|
Recent commits work towards addressing this issue. One open question persists: should Overall, how should we handle utilities? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
established PlumeMeshUtils.py so remove repeated simulation logic.
TODO: inspect extracted methods and try to understand if they belong here or should be in another class? Please read comments for further details.
NOTE: This could end up being a temporary file. If functions are better handled by other classes/files.