feat(forms): add Tag question type and category implementation #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccailly
force-pushed
the
feature/implement-tag-question-type
branch
3 times, most recently
from
59a5b9a to
1494937
Compare
Rom1-B
reviewed
Oct 6, 2025
ccailly
force-pushed
the
feature/implement-tag-question-type
branch
from
1494937 to
6a7f41b
Compare
ccailly
force-pushed
the
feature/implement-tag-question-type
branch
from
6a7f41b to
18e58e4
Compare
Rom1-B
reviewed
Oct 6, 2025
Rom1-B
reviewed
Oct 6, 2025
Co-authored-by: Romain B. <[email protected]>
ccailly
commented
Oct 7, 2025
…move unnecessary bootstrap files
4 tasks
AdrienClairembault
approved these changes
Oct 14, 2025
| use Glpi\Form\QuestionType\AbstractQuestionType; | ||
| use Glpi\Form\QuestionType\QuestionTypeCategoryInterface; | ||
|
|
||
| class PluginTagQuestionType extends AbstractQuestionType implements FormQuestionDataConverterInterface |
There was a problem hiding this comment.
Suggested change
| class PluginTagQuestionType extends AbstractQuestionType implements FormQuestionDataConverterInterface | |
| final class PluginTagQuestionType extends AbstractQuestionType implements FormQuestionDataConverterInterface |
|
|
||
| if (isset($_POST['add'])) { | ||
| $item = new PluginTagTagItem(); | ||
| class PluginTagQuestionTypeCategory implements QuestionTypeCategoryInterface |
There was a problem hiding this comment.
Suggested change
| class PluginTagQuestionTypeCategory implements QuestionTypeCategoryInterface | |
| final class PluginTagQuestionTypeCategory implements QuestionTypeCategoryInterface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Implement Tag question type
Screenshots (if appropriate):
Form editor
Form rendering