Skip to content

Generalize source object #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from
Draft

Generalize source object #61

wants to merge 21 commits into from
+1,605 −752

Conversation

btry
Copy link
Collaborator

@btry btry commented Sep 19, 2025 •
edited
Loading

Rename from CarbonIntensitySource to Source to manage sources related to other aspects of LCA.

Done:

  • update the diagnosis algorithm to use the up to date relation

TODO:

  • migrate location / zone relation from text to object
  • inherit association location / zone from ancestors of current location

@btry btry changed the base branch from develop to support/1.1.0 September 19, 2025 11:47
@btry btry changed the base branch from support/1.1.0 to develop September 19, 2025 11:48
@btry btry force-pushed the refactor/generalize_source branch from 82979d1 to f871f0c Compare September 19, 2025 12:07
@btry btry changed the base branch from develop to support/1.1.0 September 19, 2025 12:09
@btry btry changed the base branch from support/1.1.0 to develop September 19, 2025 12:09
@btry btry force-pushed the refactor/generalize_source branch 2 times, most recently from a13dfe9 to 9c87e79 Compare September 19, 2025 13:03
@btry btry force-pushed the refactor/generalize_source branch from 9c87e79 to 4cea583 Compare October 3, 2025 16:41
@btry btry force-pushed the refactor/generalize_source branch from 4cea583 to 2a7edb5 Compare October 3, 2025 16:46
@btry btry marked this pull request as draft October 3, 2025 16:48
btry added 3 commits October 6, 2025 08:55
@btry
refactor(CarbonIntensitySource): rename object to Source
1d90960 
Impacts CarbonIntensityZource_Zone, which has been renamed
Semantically unlocks the abolity to use Source object to store data for data sources other than carbon intensity
@btry
feat(Location): move plugin specific field for location to a tab
383d454
@btry
fix(ComputerType,MonitorType): more conststent right checks
ef01a80
@btry btry force-pushed the refactor/generalize_source branch from 71a0bbc to 28ca384 Compare October 6, 2025 07:10
btry added 14 commits October 6, 2025 09:59
@btry
feat(Location): associate location to a carbon intensity zone
90c5d8c
@btry
style(Impact\History\AbstractAsset): code cleanup
13ebbf0
@btry
fix(Impact\History\AbstractAsset): test memory before calculating a c…
934bf4b 
…arbon emission

A result was calculated but not saved, wasting computational resources
@btry
test: replace deprecated methods
c0a93bd
@btry
refactor(Zone): set alias to location class
3449f19
@btry
feat(Zone): update algorithms to find zone from location or asset
ca3fddd
@btry
test(Install): add message on failure
09cadd0
@btry
tst(Location): fix test method name
66ed65c
@btry
test(Impact\History\Monitor): update out of date itemtype
596a822
@btry
test: update tests with location /zone relation
aba6a16
@btry
feat(Location): associate location to a carbon intensity zone
5c096c3
@btry
fix(Install): avoid use of non-existing classes in migration code
9cdc75a
@btry
style: php lint
baed6f3
@btry
style(Zone): remove unused var
d991129
@btry btry force-pushed the refactor/generalize_source branch from 28ca384 to 250d85c Compare October 6, 2025 07:59
@btry btry mentioned this pull request Oct 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@btry