Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pattern shape mix-up between ascending and descending #475

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

bvenn
Copy link
Collaborator

@bvenn bvenn commented Nov 3, 2024

closes #474

The introduced change switches the characters that define the pattern fill shape:

Ascending stripes: "\" -> "/"
Descending stripes: "/" -> "\"

@bvenn bvenn requested a review from kMutagene November 11, 2024 10:10
@kMutagene
Copy link
Collaborator

iirc i made up these names, as plotly simply recognizes the symbols. However i can see why ascending being 'down left, up right' might make more sense

@kMutagene kMutagene merged commit c671e1e into plotly:dev Nov 13, 2024
2 checks passed
@bvenn bvenn deleted the #474-fix-patternshape branch November 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PatternShape stripe description seems to be mixed up between ascending and descending
2 participants