Skip to content

Conversation

ToeTag
Copy link

@ToeTag ToeTag commented Apr 24, 2021

No description provided.

Copy link
Owner

@plopp plopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! Please see my comments.

#Support functions

def convertToFloat(input_int):
#read_long returns a 32-bit int, convert to float...
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to be correct. From the datasheet the integer returned should be divided by 100 to get the floating point value.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BAT_SOC = 0x311A
BAT_RATED_VOLTAGE = 0x9067

BAT_VOLTAGE_MAX_DAY = 0x3302# 00: 00 Refresh every day V 100
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be some copy/paste garbage? Please remove.

print("Batt. temp:\t" + str(temperature) + "C")

gen_energy_day=instrument.read_long(
GEN_ENERGY_TODAY_L, 4, False, 0) # Registernumber, number of decimals
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated comment. Please remove.

@plopp
Copy link
Owner

plopp commented Apr 28, 2021

@ToeTag If you need anything, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants