-
Notifications
You must be signed in to change notification settings - Fork 6
Added more registers and support for total energy generated #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission! Please see my comments.
#Support functions | ||
|
||
def convertToFloat(input_int): | ||
#read_long returns a 32-bit int, convert to float... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to be correct. From the datasheet the integer returned should be divided by 100 to get the floating point value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BAT_SOC = 0x311A | ||
BAT_RATED_VOLTAGE = 0x9067 | ||
|
||
BAT_VOLTAGE_MAX_DAY = 0x3302# 00: 00 Refresh every day V 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be some copy/paste garbage? Please remove.
print("Batt. temp:\t" + str(temperature) + "C") | ||
|
||
gen_energy_day=instrument.read_long( | ||
GEN_ENERGY_TODAY_L, 4, False, 0) # Registernumber, number of decimals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeated comment. Please remove.
@ToeTag If you need anything, let me know. |
No description provided.