-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add method to 'scale' SVGs by modifying display size and viewbox #68
base: master
Are you sure you want to change the base?
Conversation
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a stupid question (because I should read more about SVG): is it possible to handle this using width/height and the object-fit
CSS property on the img
tag that references the SVG file, instead of modifying the contents of the SVG?
You can. But it is a workaround only IMO. It would need changes in many places and is orthogonal to our current image handling. We have the infrastructure to modify images, so we can "scale" and "crop" SVGs properly. Also we could then embed those instead of loading them by image tag. |
Needs to be merged before plone/plone.namedfile#133