Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change from GPL to BSD. Refs: #10 #13

Merged
merged 3 commits into from
Jan 15, 2019
Merged

change from GPL to BSD. Refs: #10 #13

merged 3 commits into from
Jan 15, 2019

Conversation

andbag
Copy link
Member

@andbag andbag commented Dec 14, 2018 •
edited by icemac
Loading

Fixes #10.

icemac
icemac requested changes Dec 17, 2018
View reviewed changes
Copy link

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current changes look good to me. Additionally the licence should be changed in setup.py (in classifiers and licencse.)

@andbag andbag closed this Jan 4, 2019
@andbag andbag reopened this Jan 4, 2019
@thet
Copy link
Member

thet commented Jan 4, 2019

A changelog entry is necessary and I believe a version increase to 2.0 would be appropriate (Following semantic versioning standards as this is a major change which breaks backwards compatibility not on an API but usage level).
Second opinion? /cc @polyester @esteele @jensens

Other than that: i'm happy that this is going to be resolved.

@esteele
Copy link
Member

esteele commented Jan 4, 2019

Let's call it 2.0

@andbag
Copy link
Member Author

andbag commented Jan 15, 2019

@timitos setup.py was already updated in c296732 of this PR. Or did I miss something?

@timitos
Copy link
Member

timitos commented Jan 15, 2019

@andbag oh. sorry. i missed that.

@andbag
Copy link
Member Author

andbag commented Jan 15, 2019

The broken test "continuous-integration/travis-ci/pr" is solved in PR #14
@icemac who merges the PR #13?

@thet thet merged commit 6a758e9 into plone:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andbag @thet @esteele @timitos @icemac @mister-roboto