Allow Contributor and Editor to Access inactive portal content

[MrTango]

fixes #3571
This should be safe to do, as Editor and Contributor have the View permission anyway.

[mister-roboto]

@MrTango thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[MrTango]

@jenkins-plone-org please run jobs

[MrTango]

@mauritsvanrees this needs an upgrade step to load the rolemap, where in plone.app.upgrade should this be added?

[davisagli]

this needs an upgrade step to load the rolemap

This is a policy decision we can make. Do we want to force everyone that upgrades to get the new rolemapping for this permission, or do we want to leave it alone for existing sites where it may have been customized?

[MrTango]

I would argue that the new behavior is the better one. Right now only administrators can really work with content which have effective date in the future. For me that's a bug, which needs to be corrected. We also should back port this at least to Plone 6.0.

[davisagli]

I would argue that the new behavior is the better one.

I agree it's a better default. If an admin customized the permissions to give this permission to non-default roles, I'm not sure we should clobber that.

[petschki]

@jenkins-plone-org please run jobs

[petschki]

The test failures seem to be related to this change: https://jenkins.plone.org/job/pull-request-6.1-3.10/508/testReport/plone.restapi.tests.test_search/TestSearchFunctional/test_respect_access_inactive_permission/

[MrTango]

@jenkins-plone-org please run jobs